Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly parse URL query before adding new parameters #393

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

byewokko
Copy link
Collaborator

@byewokko byewokko commented Jun 13, 2024

Issue

The function generic.add_params_to_url_query parses URLs with query incorrectly with list values, resulting e.g. in http://localhost:8080/login?param=['test'] instead of http://localhost:8080/login?param=test.

Solution

  • Query parameter values are parsed as strings.
  • No parameter can occur in the query more than once (e.g. ?someparam=value1&someparam=value2 is not allowed).

@byewokko byewokko added the bug Something isn't working label Jun 13, 2024
@byewokko byewokko self-assigned this Jun 13, 2024
@byewokko byewokko marked this pull request as ready for review June 13, 2024 13:18
@byewokko byewokko merged commit a5fb552 into main Jun 13, 2024
5 checks passed
@byewokko byewokko deleted the fix/parsing-request-query branch June 13, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant